Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube rebrand #2511

Merged

Conversation

davividal
Copy link
Contributor

@davividal davividal commented Dec 2, 2024

Since we are rebranding SonarQube with a new logo, naming, and offerings, we need to update the Docker documentation to properly reflect that.

Can these commits be squashed or must I do that on my side before?

@yosifkit
Copy link
Member

yosifkit commented Dec 2, 2024

Can these commits be squashed or must I do that on my side before?

We don't mind doing a "squash and merge", but if you really want to squash and force push, that is fine too.

There are a couple failing tests that need addressed:

  • sonarqube/README-short.txt is a little bit long (Docker Hub only allows 100 characters)
  • sonarqube/README.md should not be in the commits as it will be re-generated automatically after merge.

@davividal davividal force-pushed the sonarqube-community-rebrand branch from 331acf9 to 56ac9b3 Compare December 3, 2024 21:15
@davividal davividal force-pushed the sonarqube-community-rebrand branch from 56ac9b3 to db8b475 Compare December 3, 2024 21:44
@davividal
Copy link
Contributor Author

Thanks for the answer, @yosifkit.

I addressed your comments and squashed the commits.

@yosifkit yosifkit merged commit 337d5e3 into docker-library:master Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants